Duplicate condition in 'if' statement

Description

In this test file: org.activiti.engine.test.bpmn.gateway.ParallelGatewayTest.java there is a test method, testHistoryTables(), that was added to verify ACT-1755.

At line 148 there is a conditional:

if (h.getActivityId().equals("parallelgateway2") || h.getActivityId().equals("parallelgateway2")) {

where the condition on both sides of the "or" is exactly the same.

If I look at the history table under test the items history[1] and history[3] meet the condition and are the records being tested.

If one looks at the original defect report, records 70 and 73 meet the conditions.

I believe that second conditional after the "or" can be safely removed.

Environment

None

Assignee

Joram Barrez

Reporter

David Malkovsky

Labels

None

Components

Fix versions

Affects versions

Priority

Minor
Configure