Fix potential null pointer deferences and other

Description

(1) org.activiti.designer.eclipse\src\main\java\org\activiti\designer\eclipse\common\RenameActionProvider.java (around line 100)

Move the null check for the variable domain outside of the try block to prevent a null pointer deference in the finally block.

(2) org.activiti.designer.gui\src\main\java\org\activiti\designer\features\DeleteLaneFeature.java (around line 71)

Move the null check for the variable parentPool before it is deferenced in parentPool.getId()

(3) org.activiti.designer.gui\src\main\java\org\activiti\designer\property\ActivitiPropertySection.java (line 622)

Add parenthesis to get the correct operator precedence to prevent a possible null pointer dereference.

(4)
org.activiti.designer.gui\src\main\java\org\activiti\designer\util\BpmnBOUtil.java (starting at line 135)

I can find no references to the last method in the class:
public static List<FieldExtension> getFieldModelList(String fieldString)
Even if the code is called it doesn't appear to do anything as the first split() method breaks the string into single charaters (because of the "|") and then a few lines later splits that string again and then looks for strings of length 2 or greater (which can't happen) so the routine always returns an empty array.

(5) Remove unused imports in:
(a) org.activiti.designer.gui/src/main/java/org/activiti/designer/features/ContainerResizeFeature.java
(b) org.activiti.designer.gui/src/main/java/org/activiti/designer/property/PropertyDataPropertyFilter.java
(c) org.activiti.designer.kickstart.eclipse/src/main/java/org/activiti/designer/kickstart/eclipse/navigator/CmisContentProvider.java
(d) org.activiti.designer.kickstart.eclipse/src/main/java/org/activiti/designer/kickstart/eclipse/ui/CreateActivitiProjectWizard.java

I will submit a pull request for these changes.

Environment

None

Assignee

Tijs Rademakers

Reporter

David Malkovsky

Labels

None

Components

Fix versions

Affects versions

Priority

Minor
Configure