We're updating the issue view to help you get more done. 

Fix (or remove) JobEntityManagerImpl#removeExectutionLink

Description

The JobEntityManagerImpl#removeExecutionLink method is essentially a no-op, as it's trying to remove this, a JobEntityManagerImpl, from a List<JobEntity>. Here's the code:

1 2 3 4 5 6 protected void removeExecutionLink(JobEntity jobEntity) { if (jobEntity.getExecutionId() != null) { ExecutionEntity execution = getExecutionEntityManager().findById(jobEntity.getExecutionId()); execution.getJobs().remove(this); } }

That method should be changed to:

1 execution.getJobs().remove(jobEntity);

or, preferably, ExecutionEntity#getJobs should be completely removed (and just replaced with a findJobsByExecutionId call if needed perhaps?).

Link to code in GitHub:
https://github.com/Activiti/Activiti/blob/activiti6/modules/activiti-engine/src/main/java/org/activiti/engine/impl/persistence/entity/JobEntityManagerImpl.java#L293

Status

Assignee

Joram Barrez

Reporter

Logan Chadderdon

Labels

None

Components

Fix versions

Priority

Lowest